[WIP] fix: possible fix for CCI breakage#1238
Merged
asoplata merged 2 commits intojonescompneurolab:masterfrom Feb 5, 2026
Merged
[WIP] fix: possible fix for CCI breakage#1238asoplata merged 2 commits intojonescompneurolab:masterfrom
asoplata merged 2 commits intojonescompneurolab:masterfrom
Conversation
This is intended to resolve jonescompneurolab#1237. For some unknown reason, when I execute the notebook at `examples/workflows/plot_simulate_somato.py`, after installing `mne-1.11.0`. I can reproduce the issue. The issue reproduces only if Python is set to 3.13 or 3.12, but not 3.11. I think the key line in the script that is the problem is this https://github.com/jonescompneurolab/hnn-core/blob/master/examples/workflows/plot_simulate_somato.py#L45 I honestly don't know why this is suddenly an issue *now*, since it's been months since we changed the CircleCI Python version we use, and this notebook hasn't been touched in 3 years, and as far as I can tell the version of MNE being used in our CircleCI runs hasn't changed between this week and last week (both 1.11.0). I will note that the error only occurs if there is no pre-existing folder named `MNE-somato-data` in your `~/mne_data` folder. You must delete that folder every time in order to redownload it, and trigger the bug. The bug doesn't appear if you already have that folder. This PR may be good enough to fix our issue, but it's possible that we've identified some sort of weird upstream bug with `from mne.datasets import somato` that only occurs in rare situations. We should investigate and then tell MNE about it if the problem is inherent to them instead of to our notebook here.
asoplata
changed the title
Collaborator
Author
|
UGH. Now getting a completely different Sphinx-related problem that's preventing our builds from working (despite the same build, on the same Python version/etc. working locally on my machine). We maaaay want to consider "fixing" this by finally migrating our CircleCI docs build over to Github Actions like we've discussed in the past. |
Collaborator
Author
|
Okay, I think we're good. Changing the version to Python 3.11 and forcing a full CircleCI rebuild of the cache seems to fix both issues. Merging. |
asoplata
added a commit
to asoplata/textbook
that referenced
this pull request
Feb 9, 2026
Our textbook stable build is failing for the same reason as jonescompneurolab/hnn-core#1238 which is that the script/notebook that uses MNE is suddenly failing on Python 3.12 and 3.12, but not 3.11. This switches all current environments to use 3.11, which should solve the issue.
asoplata
added a commit
to jonescompneurolab/textbook
that referenced
this pull request
Feb 9, 2026
Our textbook stable build is failing for the same reason as jonescompneurolab/hnn-core#1238 which is that the script/notebook that uses MNE is suddenly failing on Python 3.12 and 3.12, but not 3.11. This switches all current environments to use 3.11, which should solve the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended to resolve #1237.
For some unknown reason, when I execute the notebook at
examples/workflows/plot_simulate_somato.py, after installingmne-1.11.0. I can reproduce the issue. The issue reproduces only if Python is set to 3.13 or 3.12, but not 3.11.I think the key line in the script that is the problem is this https://github.com/jonescompneurolab/hnn-core/blob/master/examples/workflows/plot_simulate_somato.py#L45 I honestly don't know why this is suddenly an issue now, since it's been months since we changed the CircleCI Python version we use, and this notebook hasn't been touched in 3 years, and as far as I can tell the version of MNE being used in our CircleCI runs hasn't changed between this week and last week (both 1.11.0).
I will note that the error only occurs if there is no pre-existing folder named
MNE-somato-datain your~/mne_datafolder. You must delete that folder every time in order to redownload it, and trigger the bug. The bug doesn't appear if you already have that folder.This PR may be good enough to fix our issue, but it's possible that we've identified some sort of weird upstream bug with
from mne.datasets import somatothat only occurs in rare situations. We should investigate and then tell MNE about it if the problem is inherent to them instead of to our notebook here.