Skip to content

Conversation

@chmst
Copy link
Contributor

@chmst chmst commented Nov 17, 2025

Pull Request for Issue #46446

Summary of Changes

This PR sepaprates Legend of the fieldset and label of a field

Testing Instructions

I a frontend login form click the "forgot password" link.

Actual result BEFORE applying this Pull Request

The label of the fieldset is used for a legend. If there is no label, there would not be a legend at all, which is an a11y issue.
A legend is not an instruction but summarises the content of a fieldset.
This PR adds a legend for the fieldset, if there is a label or not.

grafik ### Expected result AFTER applying this Pull Request grafik

Note:
If this is accepted, same change is needed for similiar pages.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Kostelano
Copy link
Contributor

The same issue is on the Login reminder page.
Can we fix this and do the same?

@brianteeman
Copy link
Contributor

@Kostelano it already says that

@Kostelano
Copy link
Contributor

@Kostelano it already says that

I didn't see it at first, now I see it

@ChristineWk
Copy link

I have tested this item ✅ successfully on 70e4a33


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46451.

@richard67
Copy link
Member

@chmst If this PR is a bug fix, it should be made for 5.4-dev if it effects both 5.4 and 6.0, and it seems that's the case. And if it is a new feature it should be made for 6.1-dev. So I don't really understand why you have made it for 6.0-dev.

@chmst
Copy link
Contributor Author

chmst commented Nov 17, 2025

It is an enhancment.

@brianteeman
Copy link
Contributor

it has to be made for 6.1 because there is a NEW language string (unfortunately)

@brianteeman
Copy link
Contributor

But it could be made for 5.4 if you re-use the existing string COM_USERS_RESET which for me would be better as it really is a bug fix.

@chmst
Copy link
Contributor Author

chmst commented Nov 17, 2025

Thanks @brianteeman, will do this. I also see that the fieldset label is not necessary at all.

@chmst
Copy link
Contributor Author

chmst commented Nov 17, 2025

Closing for #46454

@chmst chmst closed this Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators PR-6.0-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants