Skip to content

Conversation

@chmst
Copy link
Contributor

@chmst chmst commented Nov 17, 2025

Pull Request for Issue #46446 .
Replaces #46451

Summary of Changes

This PR sepaprates Legend of the fieldset and label of a field in all pages for password reset. (request, confirm, complete)

Testing Instructions

I a frontend login form click the "forgot password" link.

Actual result BEFORE applying this Pull Request

The label of the fieldset is used for a legend. If there is no label, there would not be a legend at all, which is an a11y issue.
A legend is not an instruction but summarises the content of a fieldset.
This PR adds a legend for the fieldset, if there is a label or not.

grafik ### Expected result AFTER applying this Pull Request grafik

Note:
If this is accepted, same change is needed for similiar pages in the users component.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Sieger66
Copy link
Contributor

@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 0510135


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46454.

1 similar comment
@hans2103
Copy link
Contributor

I have tested this item ✅ successfully on 0510135


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46454.

<legend><?php echo Text::_($fieldset->label); ?></legend>
<?php endif; ?>
<legend><?php echo Text::_('COM_USERS_COMPLETE'); ?></legend>
<p><?php echo Text::_('COM_USERS_RESET_COMPLETE_LABEL'); ?><p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, as we have only one fieldset, this code works. But we are in a loop over fieldsets here, so as soon as someone adds a new fieldset to the form, this will be a problem as the legend and text are always the same.

Would there be a better solution for this?

Or do we already do it elsewhere in the same way, having a loop over fieldsets and in that loop code using the same language strings?

No idea if it is really a problem.

@richard67 richard67 added the RMDQ ReleaseManagerDecisionQueue label Nov 20, 2025
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46454.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Accessibility bug PR-5.4-dev RMDQ ReleaseManagerDecisionQueue RTC This Pull Request is Ready To Commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants