-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[5.4] Passwort reset request: fix legend #46454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.4-dev
Are you sure you want to change the base?
Conversation
|
Same can you do at: |
|
I have tested this item ✅ successfully on 0510135 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46454. |
1 similar comment
|
I have tested this item ✅ successfully on 0510135 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46454. |
| <legend><?php echo Text::_($fieldset->label); ?></legend> | ||
| <?php endif; ?> | ||
| <legend><?php echo Text::_('COM_USERS_COMPLETE'); ?></legend> | ||
| <p><?php echo Text::_('COM_USERS_RESET_COMPLETE_LABEL'); ?><p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, as we have only one fieldset, this code works. But we are in a loop over fieldsets here, so as soon as someone adds a new fieldset to the form, this will be a problem as the legend and text are always the same.
Would there be a better solution for this?
Or do we already do it elsewhere in the same way, having a loop over fieldsets and in that loop code using the same language strings?
No idea if it is really a problem.
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46454. |
Pull Request for Issue #46446 .
Replaces #46451
Summary of Changes
This PR sepaprates Legend of the fieldset and label of a field in all pages for password reset. (request, confirm, complete)
Testing Instructions
I a frontend login form click the "forgot password" link.
Actual result BEFORE applying this Pull Request
The label of the fieldset is used for a legend. If there is no label, there would not be a legend at all, which is an a11y issue.
A legend is not an instruction but summarises the content of a fieldset.
This PR adds a legend for the fieldset, if there is a label or not.
Note:
If this is accepted, same change is needed for similiar pages in the users component.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed