[6.1] Allow the module updater to automatically delete obsolete files #46474
+34
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
As it is a new feature, this PR has to be rebased to 6.1-dev. |
Bakual
force-pushed
the
ModuleAdapter
branch
from
4f873f2 to
672d920
Compare
Bakual
requested review from
HLeithner,
Hackwar,
bembelimen,
chmst,
laoneo and
rdeutz
as code owners
Added a property to track old installed files for updates. This allows the parseFiles() method to automatically remove deleted files. Same code is already used in plugin and component adapter.
Bakual
force-pushed
the
ModuleAdapter
branch
from
672d920 to
5e56f68
Compare
Contributor
Author
Done, but I think I broke the CI and you need to restart it :-) |
richard67
changed the title
richard67
reviewed
Nov 20, 2025
richard67
reviewed
Nov 20, 2025
Member
@Bakual The easiest way to fix that is to commit a change. I've allowed myself to apply a necessary change (use |
Contributor
Author
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installer for components and plugins already automatically delete files, which are no longer present in the extension manifest. The module installer doesn't do that for some reason.
This PR proposes to add this functionality as I think it's a helpful feature for extension developers. Otherwise one has to manage a script file to delete no longer used files.
Summary of Changes
Added a property to track old installed files for updates.
This allows the parseFiles() method to automatically remove deleted files.
The Same code is already used in plugin and component adapter.
Testing Instructions
Install a module which used to have a file or folder that got deleted. Make sure it's an update (the module was already installed before).
You can fake such a module by taking any module and remove a file or folder line in the manifest and then install it.
Actual result BEFORE applying this Pull Request
The removed files or folder in the manifest are still present on the webserver after the update
Expected result AFTER applying this Pull Request
The removed files or folder in the manifest are deleted on the webserver after the update
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed