Skip to content

[6.1] Allow the module updater to automatically delete obsolete files #46474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 6.1-dev
Choose a base branch
from
+34 −1
Open

[6.1] Allow the module updater to automatically delete obsolete files #46474

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e56f68
Add oldFiles property for managing file updates
Bakual Nov 19, 2025
b339dfd
Use __DEPLOY_VERSION__ for since tag
richard67 Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 34 additions & 1 deletion libraries/src/Installer/Adapter/ModuleAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,17 @@ class ModuleAdapter extends InstallerAdapter
*/
protected $scriptElement = null;

/**
* The list of current files that are installed and is read
* from the manifest on disk in the update area to handle doing a diff
* and deleting files that are in the old files list and not in the new
* files list.
*
* @var array
* @since __DEPLOY_VERSION__
* */
protected $oldFiles = null;

/**
* Method to check if the extension is already present in the database
*
Expand Down Expand Up @@ -91,7 +102,7 @@ protected function checkExistingExtension()
protected function copyBaseFiles()
{
// Copy all necessary files
if ($this->parent->parseFiles($this->getManifest()->files, -1) === false) {
if ($this->parent->parseFiles($this->getManifest()->files, -1, $this->oldFiles) === false) {
throw new \RuntimeException(Text::_('JLIB_INSTALLER_ABORT_MOD_COPY_FILES'));
}

Expand Down Expand Up @@ -528,6 +539,28 @@ protected function setupUninstall()
$this->loadLanguage(($this->extension->client_id ? JPATH_ADMINISTRATOR : JPATH_SITE) . '/modules/' . $element);
}

/**
* Method to setup the update routine for the adapter
*
* @return void
*
* @since __DEPLOY_VERSION__
*/
protected function setupUpdates()
{
// Create a new installer because findManifest sets stuff; side effects!
$tmpInstaller = new Installer();
$tmpInstaller->setDatabase($this->getDatabase());

// Look in the extension root
$tmpInstaller->setPath('source', $this->parent->getPath('extension_root'));

if ($tmpInstaller->findManifest()) {
$old_manifest = $tmpInstaller->getManifest();
$this->oldFiles = $old_manifest->files;
}
}

/**
* Method to store the extension to the database
*
Expand Down