Skip to content

Comments

A faster DenseMatrix Symbol.iterator#3395

Merged
josdejong merged 1 commit intodevelopfrom
faster-DenseMatrix-iterator
Feb 20, 2025
Merged

A faster DenseMatrix Symbol.iterator#3395
josdejong merged 1 commit intodevelopfrom
faster-DenseMatrix-iterator

Conversation

@dvd101x
Copy link
Collaborator

@dvd101x dvd101x commented Feb 17, 2025

Hi,

This is a faster algorithm for doing Symbol.iterator and some benchmarks. It runs 3 to 4 times faster.

The main changes that increase speed are:

  • Don't clone the index in every iteration (just on function calls) about 2.4 times faster
  • Don't check if the last dimension is the last dimension on every element of the last dimension about 1.5 times faster

@josdejong
Copy link
Owner

Thanks David, this is a nice improvement 👌

@josdejong josdejong merged commit d9b609b into develop Feb 20, 2025
14 of 15 checks passed
@josdejong josdejong deleted the faster-DenseMatrix-iterator branch February 20, 2025 10:46
@josdejong
Copy link
Owner

Published now in v14.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants