Skip to content

fix: devDependency cleanup#5

Merged
dylanvorster merged 4 commits intojourneyapps-labs:mainfrom
stevensJourney:dev-dependencies
Mar 9, 2026
Merged

fix: devDependency cleanup#5
dylanvorster merged 4 commits intojourneyapps-labs:mainfrom
stevensJourney:dev-dependencies

Conversation

@stevensJourney
Copy link
Contributor

Overview

PowerSync now uses @journeyapps-labs/common-sdk for interfacing with some of our micro-services. While working with this, we noticed that a few packages in micro had vitest listed under dependencies instead of devDependencies. Because of this, downstream consumers were unnecessarily pulling in those transitive packages, which added bloat to their node_modules.

This PR moves vitest to devDependencies. No runtime code has changed.

Affected packages: @journeyapps-labs/micro-codecs and @journeyapps-labs/micro-schema.

Changes

vitest → moved to devDependencies

Only used during testing — no published type definitions reference it, so there's no reason for consumers to install it.

@types/nodekept in dependencies in micro-codecs

The published .d.ts files for micro-codecs expose Buffer in their public API (e.g. Codec<Buffer<ArrayBufferLike>, ...>). Buffer is a Node.js global typed by @types/node, so consumers need it available to compile against these types.

@types/expresskept in dependencies in micro-streaming

The published .d.ts files for micro-streaming explicitly import express types (e.g. express.Request, express.Response). Moving it to devDependencies would cause TypeScript errors for consumers who don't have @types/express installed themselves.

Additional Context

@journeyapps-labs/common-sdk depends on some of these micro packages, which is how we spotted the issue:

├─┬ @powersync/cli-core link:packages/cli-core
│ ├─┬ @journeyapps-labs/common-sdk 1.0.2
│ │ └─┬ @journeyapps-labs/micro-streaming 1.0.1
│ │   └── @journeyapps-labs/micro-schema 1.0.1

@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2026

🦋 Changeset detected

Latest commit: 246ace4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@journeyapps-labs/micro-streaming Patch
@journeyapps-labs/micro-codecs Patch
@journeyapps-labs/micro-schema Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@stevensJourney stevensJourney marked this pull request as ready for review March 9, 2026 08:01
@dylanvorster dylanvorster merged commit 32090d7 into journeyapps-labs:main Mar 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants