fix: devDependency cleanup#5
Merged
dylanvorster merged 4 commits intojourneyapps-labs:mainfrom Mar 9, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 246ace4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dylanvorster
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
PowerSync now uses
@journeyapps-labs/common-sdkfor interfacing with some of our micro-services. While working with this, we noticed that a few packages inmicrohadvitestlisted underdependenciesinstead ofdevDependencies. Because of this, downstream consumers were unnecessarily pulling in those transitive packages, which added bloat to theirnode_modules.This PR moves
vitesttodevDependencies. No runtime code has changed.Affected packages:
@journeyapps-labs/micro-codecsand@journeyapps-labs/micro-schema.Changes
vitest→ moved todevDependenciesOnly used during testing — no published type definitions reference it, so there's no reason for consumers to install it.
@types/node→ kept independenciesinmicro-codecsThe published
.d.tsfiles formicro-codecsexposeBufferin their public API (e.g.Codec<Buffer<ArrayBufferLike>, ...>).Bufferis a Node.js global typed by@types/node, so consumers need it available to compile against these types.@types/express→ kept independenciesinmicro-streamingThe published
.d.tsfiles formicro-streamingexplicitly import express types (e.g.express.Request,express.Response). Moving it todevDependencieswould cause TypeScript errors for consumers who don't have@types/expressinstalled themselves.Additional Context
@journeyapps-labs/common-sdkdepends on some of thesemicropackages, which is how we spotted the issue: