chore: fix naming typos and clean up CurrentMcpServer#64
Merged
Conversation
- Fix roleCounToJson typo → roleCountToJson in QueryItemsTool - Rename mapRowToWorkItem/mapRowToWorkItemSafe → toWorkItem/toWorkItemOrNull in SQLiteWorkItemRepository to follow Kotlin naming conventions - Replace hardcoded "13 tools" in server instructions with dynamic toolCount/toolNames derived from the registered tool list - Extract registerCommonCleanup() to deduplicate shutdown action registration between stdio and HTTP transports - Add server.onClose handler to HTTP transport for DB shutdown parity with stdio transport Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
roleCounToJsontypo in QueryItemsTool (→roleCountToJson)mapRowToWorkItem/mapRowToWorkItemSafe→toWorkItem/toWorkItemOrNullin SQLiteWorkItemRepository to follow Kotlin naming conventionstoolCount/toolNamesregisterCommonCleanup()to deduplicate shutdown registration between stdio/HTTP transportsserver.onClosehandler to HTTP transport for DB shutdown parity with stdioTest Results
All tests pass (
./gradlew :current:test— BUILD SUCCESSFUL)Review
Pure cleanup — no behavioral changes. All renamed methods are private, so no external API impact. Dynamic tool count ensures instructions string stays accurate as tools are added/removed.
MCP Items
87c6ba67— Fix naming inconsistencies and typos across codebase33edb39f— Clean up CurrentMcpServer — shutdown dedup, hardcoded count, error handling🤖 Generated with Claude Code