[voicevox] add support for device param#546
Conversation
|
thank you |
This already exists. |
mqcmd196
left a comment
There was a problem hiding this comment.
Is this param really used?
❯ git rev-parse HEAD
48c605596a8b39c913c2d49c4869476f3422a524
❯ pwd
/home/obinata/ros/review_ws/src/jsk-ros-pkg/jsk_3rdparty/3rdparty/voicevox
❯ git grep device
launch/voicevox_texttospeech.launch: <arg name="device" default="" />
node_scripts/list_speakers.py: # check device
node_scripts/list_speakers.py: for device in await client.http.request("GET", "/supported_devices"):
node_scripts/list_speakers.py: print("Device: {}".format(device))
|
The but I added them because there was no part to read them in the I tried it with USB speakers connected, and without this line, specifying the device as an argument did not work, but by adding it, I was able to specify the device. |
mqcmd196
left a comment
There was a problem hiding this comment.
Ah, I'm super sorry, but I misunderstood something. You specified the param in soundplay_node.py . That's reasonable. LGTM
|
@k-okada and kick the CI again? |
@k-okada @iory
I updated the voicevox launch file to allow specifying the speaker device name.
Here is the example.
Please review.