[panda_eus] Skip generating dual_panda.l when franka_description or xacro is old to avoid build failure#1751
Merged
k-okada merged 2 commits intojsk-ros-pkg:masterfrom Dec 13, 2022
Conversation
…ld to avoid build failure
knorth55
approved these changes
Dec 6, 2022
Member
|
can you add the version information in 👀 |
Contributor
Author
|
From my point of view, writing version to both CMakeLists.txt and package.xml seems not easy to maintenance, because these versions should be synchronized. |
Member
|
what i want to do is avoiding the build failure. |
Contributor
Author
|
Then, this PR is OK, I think. |
Member
Previously, I thought using melodic and upper is enough because I assumed all packages are up to date
Contributor
Author
knorth55
approved these changes
Dec 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another solution of #1749
Currently, buildingpanda_eusfails whenfranka_description's version is less than 0.10.0.Currently, building
panda_eusfails whenfranka_description's version is less than 0.10.0 orxacro's version is less than 1.13.14.This PR fixes it by skipping
dual_panda.lgeneration.