Migrate Button, Radio, and DropdownMenu to ShadCN and Add Tests +3 issues resolved#1709
Merged
benjagm merged 34 commits intojson-schema-org:mainfrom Jun 27, 2025
Merged
Migrate Button, Radio, and DropdownMenu to ShadCN and Add Tests +3 issues resolved#1709benjagm merged 34 commits intojson-schema-org:mainfrom
benjagm merged 34 commits intojson-schema-org:mainfrom
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1709 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 23 +5
Lines 448 477 +29
Branches 116 122 +6
=========================================
+ Hits 448 477 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benjagm
requested changes
Jun 20, 2025
Collaborator
benjagm
left a comment
There was a problem hiding this comment.
Great work Idan. I just found some weird behaviours in the clear filters button. We need to review the logic to make sure whe are clearing all the field selections after clicking the clear filter button.
Collaborator
Author
benjagm
approved these changes
Jun 27, 2025
Collaborator
benjagm
left a comment
There was a problem hiding this comment.
Looks great to me. Let's merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Button,RadioandCollapsibleelements.Issue Number:
Screenshots/videos:
Screen.Recording.2025-06-14.234317.mp4
Summary
This PR:
Button.tsx,Radio.tsx, andDropdownMenucomponents to the ShadCN library.buttoncomponent to improve dark mode compatibility (open to feedback).Does this PR introduce a breaking change?
no
Checklist
Please ensure the following tasks are completed before submitting this pull request.