Skip to content

Fix PHP 8.5 deprecation #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix PHP 8.5 deprecation #840

wants to merge 2 commits into from

Conversation

andypost
Copy link
Contributor

@DannyvdSluijs
Copy link
Collaborator

@andypost thanks for the contribution. The pipeline fails on a welcome message which isn’t important.

I’ll try to merge and release Friday. I’ll add a small comment next to the added line which explains why we do this (because of BC compatibility) and add an line to the changelog. Or if you could do this in the meantime, merging the PR would be easier.

@andypost
Copy link
Contributor Author

Thank you! added comment but I did not get how to fix welcome message

@DannyvdSluijs
Copy link
Collaborator

Thank you! added comment but I did not get how to fix welcome message

The welcome message isn't important. It isn't because of this PR but rather something else I need to checkout.

Looks great. Will merge tomorrow.

@DannyvdSluijs DannyvdSluijs mentioned this pull request Aug 29, 2025
Merged
@DannyvdSluijs
Copy link
Collaborator

@andypost apparently write access to the fork has been blocked meaning I can't push the addition to the changelog.
Since you've took the time for finding this issue I wanted to keep your commit's but still wanted to move forward as I planned to spend some time today on JSON Schema.

#841 replaces this PR whilst keeping your commits.

DannyvdSluijs added a commit that referenced this pull request Aug 29, 2025
@DannyvdSluijs @andypost
Fix PHP 8.5 $http_response_header deprecation (#841)
b1562e4 
Replaces #840 (due to blocked write access on fork)

---------

Co-authored-by: Andy Postnikov <[email protected]>
@andypost andypost deleted the php85 branch August 29, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andypost @DannyvdSluijs