Fix PHP 8.5 $http_response_header deprecation #841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
DannyvdSluijs
added a commit
that referenced
this pull request
Sep 9, 2025
This fixes a regression introduced in #841 If a process/request runs: - file_get_contents on an HTTP URL. - then a json-schema validation using a file://... URL as schema (not all schema are remotely loaded) - and `http_get_last_response_headers()` is available Then you end up with: - file_get_contents on the URL fills up the headers of that request - json-schema validation loads the schema file but using file:// there are no headers, and it seems like file_get_contents does not clear previous headers itself - http_get_last_response_headers() then returns the headers of the previous request - and then `$this->fetchContentType()` will fail unless the response headers were of the correct `application/schema+json` mime type (which is very unlikely). So this PR clears the headers before we fetch the schema, to make sure we have a clean slate. I'll probably report this to PHP as well because IMO it is a bit surprising. --------- Co-authored-by: Danny van der Sluijs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #840 (due to blocked write access on fork)