Fix allowed mode choices #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaLampert
suggested changes
Oct 29, 2025
Contributor
JoshuaLampert
left a comment
JoshuaLampert
left a comment
There was a problem hiding this comment.
Thanks. This also needs to be adjusted in the README.
JoshuaLampert
suggested changes
Oct 29, 2025
README.md
Outdated
|
|
||
| - **`deps`**: Minimize only your direct dependencies (recommended for most packages) | ||
| - **`alldeps`**: Minimize direct dependencies and weak dependencies | ||
| - **`all`**: Minimize all packages (may test issues in transitive dependencies) |
Contributor
There was a problem hiding this comment.
Suggested change
| - **`weakdeps`**: Minimize only weak dependencies |
Contributor
There was a problem hiding this comment.
This should replace the line with with the all mode. Seems like the new GitHub review is still buggy with review comments at locations not touched by the PR.
Contributor
Author
|
I think that got them all now. |
JoshuaLampert
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27