Skip to content

Fix allowed mode choices #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix allowed mode choices #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f526841
Fix allowed mode choices
ChrisRackauckas Oct 29, 2025
ca1e999
Update action.yml
ChrisRackauckas Oct 29, 2025
b4a8665
Update README.md
ChrisRackauckas Oct 29, 2025
553167e
Update README.md
ChrisRackauckas Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ minimal versions and fail if your compat bounds are too low.
# Default: .
projects: ''

# Downgrade mode: 'deps' (direct dependencies), 'alldeps' (deps + weakdeps), 'all' (all packages)
# Downgrade mode: 'deps' (direct dependencies), 'alldeps' (deps + weakdeps), 'weakdeps' (only weakdeps)
# Default: 'alldeps'
mode: ''

Expand Down Expand Up @@ -88,7 +88,7 @@ The `skip:` input says that we should not attempt to downgrade `Pkg` or `TOML`.

- **`deps`**: Minimize only your direct dependencies (recommended for most packages)
- **`alldeps`**: Minimize direct dependencies and weak dependencies
- **`all`**: Minimize all packages (may test issues in transitive dependencies)
- **`weakdeps`**: Minimize only weak dependencies

**Recommendation**: Use `deps` mode for most packages as it focuses on testing your actual compat bounds without being affected by issues in transitive dependencies that you can't control.

Expand Down
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ inputs:
description: 'Comma-separated list of Julia projects to resolve.'
default: '.'
mode:
description: 'Downgrade mode: deps (direct dependencies), alldeps (deps + weakdeps), all (all packages)'
description: 'Downgrade mode: deps (direct dependencies), alldeps (deps + weakdeps), weakdeps (only weakdeps)'
default: 'alldeps'
julia_version:
description: 'Julia version to use with resolver (default: 1.10)'
Expand Down
4 changes: 2 additions & 2 deletions downgrade.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ dirs = filter(!isempty, map(strip, split(ARGS[2], ",")))
mode = length(ARGS) >= 3 ? ARGS[3] : "deps"
julia_version = length(ARGS) >= 4 ? ARGS[4] : "1.10"

mode in ["deps", "alldeps", "all"] || error("mode must be deps, alldeps, or all")
mode in ["deps", "alldeps", "weakdeps"] || error("mode must be deps, alldeps, or weakdeps")

@info "Using Resolver.jl with mode: $mode"

Expand All @@ -25,4 +25,4 @@ for dir in dirs
@info "Running resolver on $dir with --min=@$mode"
run(`julia --project=$resolver_path/bin $resolver_path/bin/resolve.jl $dir --min=@$mode --julia=$julia_version`)
@info "Successfully resolved minimal versions for $dir"
end
end