PHP8.5 #500
Open
PHP8.5 #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request addresses PHP 8.5 compatibility issues by fixing parameter types and avoiding deprecated functions.
Changes:
- Fixed
http_build_query()call to use empty string instead of null for the second parameter - Added version check to conditionally skip
curl_close()call to avoid deprecation warnings - Updated CHANGELOG with entries for both fixes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/OpenIDConnectClient.php | Fixed http_build_query null parameter and added PHP version check for curl_close |
| CHANGELOG.md | Added changelog entries documenting both PHP 8.5 compatibility fixes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
antoineveldhoven
force-pushed
the
PHP8.5
branch
from
6086828 to
bd65e67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http_build_query expects a string, null no longer allowed.
curl_close() since PHP 8.0.0 ineffective, since 8.5.0 deprecated.