Skip to content

PHP8.5 #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antoineveldhoven wants to merge 3 commits into
base: master
Choose a base branch
from
+6 −2
Open

PHP8.5 #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e13154e
http_build_query expects a string, null no longer allowed.
antoineveldhoven Jan 15, 2026
411a9ea
curl_close() since PHP 8.0.0 ineffective, since 8.5.0 deprecated.
antoineveldhoven Jan 15, 2026
bd65e67
Update changelog.
antoineveldhoven Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- Check existence of subject when verifying JWT #474
- exp verification when verifying Logout Token claims #482
- http_build_query expects (non nullable) string as 2nd argument
- curl_close() is ineffective since PHP 8.0.0, deprecated since 8.5.0

## [1.0.1] - 2024-09-13

Expand Down
6 changes: 4 additions & 2 deletions src/OpenIDConnectClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,7 +972,7 @@ public function requestTokenExchange(string $subjectToken, string $subjectTokenT
}

// Convert token params to string format
$post_params = http_build_query($post_data, null, '&', $this->encType);
$post_params = http_build_query($post_data, '', '&', $this->encType);

return json_decode($this->fetchURL($token_endpoint, $post_params, $headers), false);
}
Expand Down Expand Up @@ -1446,7 +1446,9 @@ protected function fetchURL(string $url, ?string $post_body = null, array $heade
}

// Close the cURL resource, and free system resources
curl_close($ch);
if (PHP_VERSION_ID < 80000) {
curl_close($ch);
}

return $output;
}
Expand Down