Skip to content

Set explicit artifact_name when uploading coverage data #7457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Set explicit artifact_name when uploading coverage data #7457

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
19c4d49
Set explicit `artifact_name` when uploading coverage data
jtpio Sep 10, 2024
e84c0c1
fix typo
jtpio Sep 10, 2024
5786d58
upload after tests
jtpio Sep 10, 2024
e80a492
debug
jtpio Sep 10, 2024
34da4fb
dbg
jtpio Sep 10, 2024
2f3dc7c
wip
jtpio Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ jobs:
- name: Test the package
run: hatch run cov:test

- uses: jupyterlab/maintainer-tools/.github/actions/upload-coverage@main
with:
artifact_name: coverage-${{ matrix.python-version }}

- name: JavaScript tests
run: |
hatch run js_test
Expand All @@ -61,15 +65,13 @@ jobs:
jupyter server extension list 2>&1 | grep -ie "notebook.*enabled" -
python -m jupyterlab.browser_check

- uses: jupyterlab/maintainer-tools/.github/actions/upload-coverage@v1

coverage:
runs-on: ubuntu-latest
needs:
- test
steps:
- uses: actions/checkout@v4
- uses: jupyterlab/maintainer-tools/.github/actions/report-coverage@v1
- uses: jtpio/maintainer-tools/.github/actions/report-coverage@include-hidden-files-2
with:
fail_under: 78

Expand Down