Follow up #592 #597
Merged
Follow up #592 #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
force-pushed
the
connect_to_unix_socket
branch
from
3f0b937 to
c5c081e
Compare
agoose77
commented
Sep 19, 2025
Comment on lines
+400
to
+405
| } else if (target.protocol.startsWith("https")) { | ||
| proxyOptions.secure = true; | ||
| proxyOptions.agent = this.httpsAgent; | ||
| } else if (target.protocol.startsWith("http")) { | ||
| proxyOptions.secure = false; | ||
| proxyOptions.agent = this.httpAgent; |
There was a problem hiding this comment.
This is more robust to close the set of protocols.
| var proxyOptions = { target }; | ||
|
|
||
| if (target.protocol.startsWith("unix")) { | ||
| // No need for agents for unix sockets |
There was a problem hiding this comment.
Comment belongs here.
Comment on lines
+19
to
+22
| proto = "http"; | ||
| target = "unix+" + proto + "://" + unixSocketPath; | ||
| } else { | ||
| proto = sslOptions ? "https" : "http"; |
There was a problem hiding this comment.
Force HTTP for unix
Closed
2 tasks
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I performed a review of #592, but without admin privs the changes were only on my fork. This PR follows up #592 with my suggestions!