Skip to content

Add proxy.service.externalIPs config #3683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 1, 2025
Merged

Add proxy.service.externalIPs config #3683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eac32d7
feat: add externalIPs to proxy configuration
holzman Apr 23, 2025
8ba2837
Prefer use of toYaml over range
consideRatio Jun 1, 2025
523b1d2
Validate rendering of externalIPs
consideRatio Jun 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions jupyterhub/templates/proxy/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,3 +81,7 @@ spec:
{{- . | toYaml | nindent 4 }}
{{- end }}
{{- end }}
{{- with .Values.proxy.service.externalIPs }}
externalIPs:
{{- . | toYaml | nindent 4 }}
{{- end }}
6 changes: 6 additions & 0 deletions jupyterhub/values.schema.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1751,6 +1751,12 @@ properties:
See [the Kubernetes
documentation](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.23/#serviceport-v1-core)
for the structure of the items in this list.
externalIPs:
type: array
description: |
A list of external IP addresses (unmanaged by Kubernetes) for which
nodes in the cluster will accept traffic for this service.
See [externalIPs](https://kubernetes.io/docs/concepts/services-networking/service/#external-ips) for more details.
loadBalancerIP:
type: [string, "null"]
description: |
Expand Down
1 change: 1 addition & 0 deletions jupyterhub/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ proxy:
https:
disableHttpPort: false
extraPorts: []
externalIPs: []
loadBalancerIP:
loadBalancerSourceRanges: []
# chp relates to the proxy pod, which is responsible for routing traffic based
Expand Down
3 changes: 3 additions & 0 deletions tools/templates/lint-and-validate-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,9 @@ proxy:
nodePorts:
http:
https:
externalIPs:
- 123.123.123.123
- 123.123.123.124
chp:
revisionHistoryLimit: 1
extraCommandLineFlags:
Expand Down
Loading