Skip to content

Conversation

sunu
Copy link
Contributor

@sunu sunu commented Jun 12, 2025

KubeSpawner now supports dict values for volumes, volume_mounts etc. This allows for easy overriding when required. ref: jupyterhub/kubespawner#843 and jupyterhub/kubespawner#845

This PR makes sure jupyterhub_config.py also support defining these values as dictionaries and changes the default of these list based configurations to be dict.

Co-authored-by: Angus Hollands <[email protected]>
@agoose77
Copy link
Contributor

Thanks for the PR @sunu!

@GeorgianaElena and I took a look at reviewing this and merging it. We changed a few small details with code-style (mainly replacing .update with assignment, and loops with .update), and update the docs to clarify that they keys are not required to match the volume/mount names.

We wanted to note explicitly that if users already had extraVolumes whose names shadow e.g. files or home, then these will now clobber the definitions instead of being passed through to k8s. We think this represents a new feature -- that existing configurations are not valid if they define duplicate volumes.

@GeorgianaElena GeorgianaElena merged commit 23949e5 into jupyterhub:main Aug 19, 2025
15 of 16 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in PR triage (experimental) Aug 19, 2025
consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants