-
Notifications
You must be signed in to change notification settings - Fork 826
Support dict values for volumes, volume_mounts and other list based configs that support dict values #3690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dict values for volumes, volume_mounts and other list based configs that support dict values #3690
Conversation
for more information, see https://pre-commit.ci
Co-authored-by: Angus Hollands <[email protected]>
Co-authored-by: Angus Hollands <[email protected]>
Co-authored-by: Angus Hollands <[email protected]>
Co-authored-by: Angus Hollands <[email protected]>
Thanks for the PR @sunu! @GeorgianaElena and I took a look at reviewing this and merging it. We changed a few small details with code-style (mainly replacing We wanted to note explicitly that if users already had |
jupyterhub/zero-to-jupyterhub-k8s#3690 Merge pull request #3690 from sunu/volume-volumemounts-as-dict
KubeSpawner now supports dict values for volumes, volume_mounts etc. This allows for easy overriding when required. ref: jupyterhub/kubespawner#843 and jupyterhub/kubespawner#845
This PR makes sure
jupyterhub_config.py
also support defining these values as dictionaries and changes the default of these list based configurations to be dict.