fix: initialize constraints list for install action#262
Open
JCapul wants to merge 1 commit intojupyterlite:mainfrom
Open
fix: initialize constraints list for install action#262JCapul wants to merge 1 commit intojupyterlite:mainfrom
JCapul wants to merge 1 commit intojupyterlite:mainfrom
Conversation
The "constraints" entry in install action kwargs was not initialized leading to an exception when using the --constraints option.
Contributor
bollwyvl
approved these changes
Feb 19, 2026
|
|
||
| if action == "install": | ||
| kwargs["requirements"] = args.packages | ||
| kwargs["constraints"] = [] |
Contributor
There was a problem hiding this comment.
this is fine, or could be a kwargs.setdefault("constraints", []).append() below.
Author
There was a problem hiding this comment.
thx for the review, I find it simpler and more explicit as it is, but let me know if you prefer it the other way, no pb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I hit a bug in the currently deployed version of JupyterLite (the try out version) when trying to use piplite install with a constraint file. I had a look at the code and realized the install action kwargs was not initialized for the "constraints" entry.
So here is a very quick fix.
I didn't find any related tests to update as well, so I thought I'd just issue this PR.
Let me know if I should update any other part to make it a proper fix.
To reproduce:
%pip install -c pip_list.txt pep8Then I got this error: