Skip to content

fix: initialize constraints list for install action #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JCapul wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: initialize constraints list for install action #262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/pyodide-kernel/py/piplite/piplite/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ async def get_action_kwargs(argv: list[str]) -> tuple[str | None, dict[str, Any]

if action == "install":
kwargs["requirements"] = args.packages
kwargs["constraints"] = []
Copy link
Contributor

@bollwyvl bollwyvl Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine, or could be a kwargs.setdefault("constraints", []).append() below.

Copy link
Author

@JCapul JCapul Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the review, I find it simpler and more explicit as it is, but let me know if you prefer it the other way, no pb.


if args.pre:
kwargs["pre"] = True
Expand Down