Skip to content

Conversation

@anutosh491
Copy link
Contributor

@anutosh491 anutosh491 commented Apr 17, 2025

Screen.Recording.2025-04-17.at.1.47.31.PM.mp4

Demo above : Shows 3 xeus-cpp-lite kernels built (all use different flags -std=c++17/20/23)

On top of which xcpp20 is built using the -msimd128 flag (required for running xsimd in the browser)

  "argv": [
      "@XEUS_CPP_KERNELSPEC_PATH@xcpp",
      "-resource-dir", "@XEUS_CPP_RESOURCE_DIR@",
      "-std=c++20", "-msimd128"
  ],
  
// instead of 

  "argv": [
      "@XEUS_CPP_KERNELSPEC_PATH@xcpp",
      "-resource-dir", "@XEUS_CPP_RESOURCE_DIR@",
      "-std=c++23", 
  ],

So xcpp20 kernel would work but xcpp23 wouldn't !

@anutosh491
Copy link
Contributor Author

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion to hopefully make the CI pass, and support old kernels

@martinRenou martinRenou added the enhancement New feature or request label Apr 29, 2025
@anutosh491 anutosh491 marked this pull request as ready for review April 29, 2025 14:01
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit ddcb13c into jupyterlite:main Apr 29, 2025
10 checks passed
@anutosh491 anutosh491 deleted the kernel_construction branch April 29, 2025 14:07
@martinRenou
Copy link
Member

@meeseeksdev please backport to 3.x

@lumberbot-app
Copy link

lumberbot-app bot commented Apr 29, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 ddcb13c5cfe8bc3fc6c666ed7360ca222b945fbd
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #210: Enable Kernels to be built on top of kernlSpec arguments'
  1. Push to a named branch:
git push YOURFORK 3.x:auto-backport-of-pr-210-on-3.x
  1. Create a PR against branch 3.x, I would have named this PR:

"Backport PR #210 on branch 3.x (Enable Kernels to be built on top of kernlSpec arguments)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

anutosh491 added a commit to anutosh491/jupyterlite-xeus that referenced this pull request Apr 29, 2025
…#210)

* Enable Kernels to be built on top of kernlSpec arguments

* apply suggestion

* better formatting

* Update packages/xeus/src/worker.ts

Co-authored-by: martinRenou <[email protected]>

---------

Co-authored-by: martinRenou <[email protected]>
(cherry picked from commit ddcb13c)
martinRenou added a commit that referenced this pull request Apr 29, 2025
…kernlSpec arguments) (#216)

* Enable Kernels to be built on top of kernlSpec arguments (#210)

* Enable Kernels to be built on top of kernlSpec arguments

* apply suggestion

* better formatting

* Update packages/xeus/src/worker.ts

Co-authored-by: martinRenou <[email protected]>

---------

Co-authored-by: martinRenou <[email protected]>
(cherry picked from commit ddcb13c)

* Update snapshots

---------

Co-authored-by: martinRenou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants