Skip to content

Enable Kernels to be built on top of kernlSpec arguments #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 29, 2025
Merged

Enable Kernels to be built on top of kernlSpec arguments #210

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f6556c
Enable Kernels to be built on top of kernlSpec arguments
anutosh491 Apr 17, 2025
11ed253
Merge branch 'main' into kernel_construction
anutosh491 Apr 29, 2025
071200c
apply suggestion
anutosh491 Apr 29, 2025
7882377
better formatting
anutosh491 Apr 29, 2025
439fc22
Update packages/xeus/src/worker.ts
anutosh491 Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/xeus/src/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ export abstract class XeusRemoteKernel {

this._initializeStdin(baseUrl, browsingContextId);

rawXKernel = new globalThis.Module.xkernel();
rawXKernel = new globalThis.Module.xkernel(kernelSpec.argv);
rawXServer = rawXKernel.get_server();
if (!rawXServer) {
this._logger.error('Failed to start kernel!');
Expand Down
Loading