refactor(nextjs-app-v14): DSW-3178 Added freeze for animation for spinner and chip#352
Open
JoshuaNg2332 wants to merge 1 commit intomainfrom
Open
refactor(nextjs-app-v14): DSW-3178 Added freeze for animation for spinner and chip#352JoshuaNg2332 wants to merge 1 commit intomainfrom
JoshuaNg2332 wants to merge 1 commit intomainfrom
Conversation
fernandofranca
approved these changes
Oct 6, 2025
| { url: '/components/checkbox', name: 'Checkbox' }, | ||
| { url: '/components/checkbox-group', name: 'Checkbox Group' }, | ||
| { url: '/components/chip', name: 'Chip' }, | ||
| { url: '/components/chip', name: 'Chip', pauseBeforeScreenshot: true }, |
Contributor
There was a problem hiding this comment.
I'm unsure if this pause will be enough to prevent each spinner screenshot being slightly different.
Contributor
Author
There was a problem hiding this comment.
Yeah I was thinking that as well. Do you reckon it would need to be longer?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.