Skip to content

refactor(nextjs-app-v14): DSW-3178 Added freeze for animation for spinner and chip #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoshuaNg2332 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(nextjs-app-v14): DSW-3178 Added freeze for animation for spinner and chip #352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nextjs-app-v14/test/visual/nextjs.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ describe('NextJS Aperture App', () => {
{ url: '/components/card', name: 'Card' },
{ url: '/components/checkbox', name: 'Checkbox' },
{ url: '/components/checkbox-group', name: 'Checkbox Group' },
{ url: '/components/chip', name: 'Chip' },
{ url: '/components/chip', name: 'Chip', pauseBeforeScreenshot: true },
Copy link
Copy Markdown
Contributor

@fernandofranca fernandofranca Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure if this pause will be enough to prevent each spinner screenshot being slightly different.

Copy link
Copy Markdown
Contributor Author

@JoshuaNg2332 JoshuaNg2332 Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was thinking that as well. Do you reckon it would need to be longer?

{ url: '/components/cookie-banner', name: 'Cookie Banner' },
{ url: '/components/divider', name: 'Divider' },
{ url: '/integrations/uncontrolled-form', name: 'Uncontrolled Form' },
Expand All @@ -25,7 +25,7 @@ describe('NextJS Aperture App', () => {
{ url: '/components/notification', name: 'Notification' },
{ url: '/components/radio', name: 'Radio' },
{ url: '/components/radio-group', name: 'Radio Group' },
{ url: '/components/spinner', name: 'Spinner' },
{ url: '/components/spinner', name: 'Spinner', pauseBeforeScreenshot: true },
{ url: '/components/switch', name: 'Switch' },
{ url: '/components/select', name: 'Select' },
{ url: '/components/tag', name: 'Tag' },
Expand Down
Loading