chore: 배포 기준이 되는 branch 변경

[aaaaaattt]

기존 : main
변경 후 : develop

develop 기준으로 더 빠른 배포 테스트를 위해 수정합니다.

Summary by CodeRabbit

• Chores
  • Adjusted automatic release trigger to a different development branch; users may see releases appear at different times.
  • Changed how uploaded assets are published so public-read is no longer enforced by default; this may affect direct access to certain hosted assets.
  • No changes to app UI or features in this update.

[gemini-code-assist]

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

[coderabbitai]

Walkthrough

The GitHub Actions workflow was updated to trigger the deploy job on pushes to the develop branch instead of main, and the AWS S3 sync step was modified to remove the --acl public-read flag; no other workflow steps were changed.

Changes

Cohort / File(s)	Summary of Changes
CI/CD Workflow .github/workflows/fe-ci-cd.yml	Deploy job condition changed to run on pushes to develop (was main); aws s3 sync invocation had the --acl public-read flag removed; all other steps unchanged.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Dev as Developer
    participant GH as GitHub
    participant WF as Workflow: fe-ci-cd
    participant DEP as Deploy Job
    participant S3 as AWS S3

    Dev->>GH: Push commit
    GH->>WF: Trigger workflow
    alt Branch == develop
        WF->>DEP: Start deploy job
        DEP->>S3: Run `aws s3 sync` (without `--acl public-read`)
        S3-->>DEP: Sync objects (default ACLs applied)
        DEP-->>WF: Deploy steps complete
    else Branch != develop
        WF-->>WF: Skip deploy job
    end

Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I’m a rabbit in CI, I hop and I cheer,
Now I listen to develop when pipelines appear.
The sync lost a flag, but I nibble a treat,
Deploys still hum — soft pawed and neat. 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title clearly states that the deployment branch has been changed and uses conventional commit format to indicate a chore, directly reflecting the primary change of updating the deploy trigger from main to develop.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/change-deploy-branch

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dcf65d7 and 74105cb.

📒 Files selected for processing (1)

• .github/workflows/fe-ci-cd.yml (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• .github/workflows/fe-ci-cd.yml

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ce21771 and dcf65d7.

📒 Files selected for processing (1)

• .github/workflows/fe-ci-cd.yml (1 hunks)

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

Deploy job will never run

The workflow still only triggers on push to main, but this job now requires github.ref == 'refs/heads/develop'. Since pushes to develop never start the workflow, the deploy step is now dead code—deployment will never happen. Update the workflow trigger (or revert the condition) so the deploy job can actually execute.

 on:
   pull_request:
     branches: ['develop']
   push:
-    branches: ['main']
+    branches: ['develop']

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	if: github.event_name == 'push' && github.ref == 'refs/heads/develop'
	on:
	pull_request:
	branches: ['develop']
	push:
	branches: ['develop']

🤖 Prompt for AI Agents

.github/workflows/fe-ci-cd.yml around line 117: the deploy job is gated by if:
github.event_name == 'push' && github.ref == 'refs/heads/develop' but the
workflow trigger still only fires on pushes to main, so the deploy job will
never run; fix by either updating the workflow's on.push.branches to include
'develop' (or use a wider pattern like ['main','develop']) so pushes to develop
start the workflow, or revert/change the job condition to match the existing
trigger (e.g., check for refs/heads/main or remove the github.ref check) so the
deploy job can execute.