Skip to content

chore: 배포 기준이 되는 branch 변경 #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaaaaattt merged 2 commits into from
Oct 15, 2025
Merged

chore: 배포 기준이 되는 branch 변경 #169

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcf65d7
chore: 배포 기준이 되는 branch 변경
aaaaaattt Oct 14, 2025
74105cb
chore: acl public read 제거
Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/fe-ci-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ jobs:
deploy:
runs-on: ubuntu-latest
needs: build
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
if: github.event_name == 'push' && github.ref == 'refs/heads/develop'
Copy link

@coderabbitai coderabbitai bot Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Deploy job will never run

The workflow still only triggers on push to main, but this job now requires github.ref == 'refs/heads/develop'. Since pushes to develop never start the workflow, the deploy step is now dead code—deployment will never happen. Update the workflow trigger (or revert the condition) so the deploy job can actually execute.

 on:
   pull_request:
     branches: ['develop']
   push:
-    branches: ['main']
+    branches: ['develop']
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
if: github.event_name == 'push' && github.ref == 'refs/heads/develop'
on:
pull_request:
branches: ['develop']
push:
branches: ['develop']
🤖 Prompt for AI Agents 
.github/workflows/fe-ci-cd.yml around line 117: the deploy job is gated by if:
github.event_name == 'push' && github.ref == 'refs/heads/develop' but the
workflow trigger still only fires on pushes to main, so the deploy job will
never run; fix by either updating the workflow's on.push.branches to include
'develop' (or use a wider pattern like ['main','develop']) so pushes to develop
start the workflow, or revert/change the job condition to match the existing
trigger (e.g., check for refs/heads/main or remove the github.ref check) so the
deploy job can execute.

environment: dongarium
steps:
- name: Download build artifact
Expand Down