Remove num_glyphs, deprecate Effect type tokens and highlighting functions#133
Merged
Remove num_glyphs, deprecate Effect type tokens and highlighting functions#133
Effect type tokens and highlighting functions#133Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
num_glyphswas originally added for "API completeness"'s sake, but has never been of use to Kas (and probably isn't useful elsewhere either) hence is removed.Since #132 allowed effect tokens to be defined in downstream crates and Kas has reason to use types which can't trivially be moved up to kas-text,
EffectandEffectFlagsare no longer used.Markdownrequires these specific types, hencekas-corenow has a copy ofMarkdown. These are thus deprecated.Highlighting text now uses background colours defined by effect tokens in Kas, hence the text-highlighting functions are no longer used. The result is also slightly more accurate in RTL text. The new method isn't bug free, but I don't expect to go back to these methods, hence they are deprecated.