fix(Record): clear media element source when no URL is provided#4113
Merged
katspaugh merged 1 commit intokatspaugh:mainfrom Jun 24, 2025
Merged
fix(Record): clear media element source when no URL is provided#4113katspaugh merged 1 commit intokatspaugh:mainfrom
katspaugh merged 1 commit intokatspaugh:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Resolves #4039
Fixes the continuous warning logging on Firefox
Implementation details
Instead of setting
srcto''when loading the data from record plugin to wavesurfer, thesrcattribute is removed.I also updated other places where
srcwas set to''as the media element interprets it as relative path.I left the
''URL being passed toload, but maybe passingnullinstead would be safer. Let me know if I should change that.How to test it
Start recording with record plugin on Firefox on the record example page
Screenshots
Checklist