Skip to content

fix(Record): clear media element source when no URL is provided #4113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
katspaugh merged 1 commit into from
Jun 24, 2025
Merged

fix(Record): clear media element source when no URL is provided #4113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/player.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class Player<T extends GeneralEventTypes> extends EventEmitter<T> {

// Reset the media element, otherwise it keeps the previous source
if (src) {
this.media.src = ''
this.media.removeAttribute('src')
}

try {
Expand All @@ -90,7 +90,7 @@ class Player<T extends GeneralEventTypes> extends EventEmitter<T> {
this.media.pause()
this.media.remove()
this.revokeSrc()
this.media.src = ''
this.media.removeAttribute('src')
// Load resets the media element to its initial state
this.media.load()
}
Expand Down
9 changes: 7 additions & 2 deletions src/wavesurfer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,8 +451,13 @@ class WaveSurfer extends Player<WaveSurferEvents> {
}
}

// Set the mediaelement source
this.setSrc(url, blob)
if (url == '') {
// If no URL is provided, clear the mediaelement source
this.getMediaElement().removeAttribute('src')
} else {
// Set the mediaelement source
this.setSrc(url, blob)
}

// Wait for the audio duration
const audioDuration = await new Promise<number>((resolve) => {
Expand Down
Loading