Fix(Regions): region can't be dragged to position 0 and duration.#4199
Merged
katspaugh merged 2 commits intokatspaugh:mainfrom Sep 23, 2025
xiaoliyooo:main
Merged
Fix(Regions): region can't be dragged to position 0 and duration.#4199katspaugh merged 2 commits intokatspaugh:mainfrom xiaoliyooo:main
katspaugh merged 2 commits intokatspaugh:mainfrom
xiaoliyooo:main
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where regions cannot be dragged to the start (position 0) or end (duration) positions, addressing spacing issues during region dragging.
- Removed boundary checks that prevented dragging to position 0 and duration
- Added explicit clamping to ensure regions stay within valid bounds
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
Author
Bro, you probably forgot to merge😀. |
Owner
|
Merged :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Resolves #
When dragging a region, can't be dragged to the start and end positions: 0 and duration.
There will be very little spacing
Implementation details
How to test it
Screenshots
Checklist