Skip to content

Fix(Regions): region can't be dragged to position 0 and duration. #4199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
katspaugh merged 2 commits into from
Sep 23, 2025
Merged

Fix(Regions): region can't be dragged to position 0 and duration. #4199

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6f1c69
Fix(Regions): region can't be dragged to position 0 and duration.
xiaoliyooo Sep 22, 2025
ff534d5
chore:(Regions): move the length calculation
xiaoliyooo Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/plugins/regions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,6 @@ class SingleRegion extends EventEmitter<RegionEvents> implements Region {
const deltaSeconds = (dx / width) * this.totalDuration
let newStart = !side || side === 'start' ? this.start + deltaSeconds : this.start
let newEnd = !side || side === 'end' ? this.end + deltaSeconds : this.end
const length = newEnd - newStart

if (this.updatingSide && this.updatingSide !== side && startTime !== undefined) {
if (this.updatingSide === 'start') {
Expand All @@ -305,15 +304,13 @@ class SingleRegion extends EventEmitter<RegionEvents> implements Region {
}
}

newStart = Math.max(0, newStart)
newEnd = Math.min(this.totalDuration, newEnd)
const length = newEnd - newStart

this.updatingSide = side

if (
newStart >= 0 &&
newEnd <= this.totalDuration &&
newStart <= newEnd &&
length >= this.minLength &&
length <= this.maxLength
) {
if (newStart <= newEnd && length >= this.minLength && length <= this.maxLength) {
this.start = newStart
this.end = newEnd

Expand Down
Loading