fix region overlap detection code #4270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If calls to addRegion() came in all at once, we'd end up in a situation where all overlapping regions moved themselves to avoid each other (because they were all working with the same list of regions). This is incorrect, the first region shouldn't move at all. We leverage the ordering of the `regions` array to ensure that only the later overlapping regions move.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
If calls to addRegion() came in all at once, we'd end up in a situation where all overlapping regions moved themselves to avoid each other (because they were all working with the same list of regions). This is incorrect, the first region shouldn't move at all. We leverage the ordering of the
regionsarray to ensure that only the later overlapping regions move.And I added 2 pixels of room because it just looks nicer.
Screenshots
before:
after:
