Skip to content

fix region overlap detection code #4270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
katspaugh merged 1 commit into from
Jan 4, 2026
+6 −2
Merged

fix region overlap detection code #4270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/plugins/regions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,16 +639,20 @@ class RegionsPlugin extends BasePlugin<RegionsPluginEvents, RegionsPluginOptions
setTimeout(() => {
// Check that the label doesn't overlap with other labels
// If it does, push it down until it doesn't
// only check regions that are before us in the list -- otherwise
// both overlapping regions will try to move down away from each other.
const div = region.content as HTMLElement
const box = div.getBoundingClientRect()

const overlap = this.regions
const regionIndex = this.regions.indexOf(region)

const overlap = this.regions.slice(0, regionIndex)
.map((reg) => {
if (reg === region || !reg.content) return 0

const otherBox = reg.content.getBoundingClientRect()
if (box.left < otherBox.left + otherBox.width && otherBox.left < box.left + box.width) {
return otherBox.height
return otherBox.height + 2
}
return 0
})
Expand Down
Loading