Skip to content

Conversation

@sttts
Copy link
Member

@sttts sttts commented Jan 26, 2025

Summary

With service accounts valid (even as system:anonymous+system:authenticated) on other clusters, we have to validate them on other shards. As there are many service accounts, we cannot distribute them via the cache server. But luckily there are not many those service accounts. We can use some ttl cache for that and use a real external client.

TODO

  • wire external client

Related issue(s)

Fixes # #3289

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Jan 26, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sttts. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 26, 2025
@embik embik added this to the v0.27.0 milestone Feb 4, 2025
@embik embik mentioned this pull request Feb 10, 2025
@embik embik removed this from the v0.27.0 milestone Feb 24, 2025
@kcp-ci-bot kcp-ci-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2025
@sttts sttts force-pushed the sttts-sa-lookup-cache branch from c6c34c8 to 82d13e5 Compare February 24, 2025 21:10
@kcp-ci-bot kcp-ci-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2025
@kcp-ci-bot kcp-ci-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2025
@kcp-ci-bot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gman0 pushed a commit to gman0/kubernetes that referenced this pull request Apr 17, 2025
TODO: this commit may be dropped once kcp-dev/kcp#3274 and related issues are done

Signed-off-by: Karol Szwaj <[email protected]>

On-behalf-of: @SAP [email protected]
gman0 pushed a commit to gman0/kubernetes that referenced this pull request Apr 24, 2025
TODO: this commit may be dropped once kcp-dev/kcp#3274 and related issues are done

Signed-off-by: Karol Szwaj <[email protected]>

On-behalf-of: @SAP [email protected]
gman0 pushed a commit to gman0/kubernetes that referenced this pull request Apr 25, 2025
TODO: this commit may be dropped once kcp-dev/kcp#3274 and related issues are done

Signed-off-by: Karol Szwaj <[email protected]>

On-behalf-of: @SAP [email protected]
@kcp-ci-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kcp-ci-bot kcp-ci-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 14, 2025
ntnn pushed a commit to ntnn/kubernetes that referenced this pull request Jul 8, 2025
TODO: this commit may be dropped once kcp-dev/kcp#3274 and related issues are done

Signed-off-by: Karol Szwaj <[email protected]>

On-behalf-of: @SAP [email protected]
Signed-off-by: Nelo-T. Wallus <[email protected]>
ntnn pushed a commit to ntnn/kubernetes that referenced this pull request Jul 9, 2025
TODO: this commit may be dropped once kcp-dev/kcp#3274 and related issues are done

Signed-off-by: Karol Szwaj <[email protected]>

On-behalf-of: @SAP [email protected]
Signed-off-by: Nelo-T. Wallus <[email protected]>
@kcp-ci-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kcp-ci-bot kcp-ci-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 14, 2025
ntnn pushed a commit to ntnn/kubernetes that referenced this pull request Jul 14, 2025
TODO: this commit may be dropped once kcp-dev/kcp#3274 and related issues are done

Signed-off-by: Karol Szwaj <[email protected]>

On-behalf-of: @SAP [email protected]
Signed-off-by: Nelo-T. Wallus <[email protected]>
ntnn pushed a commit to ntnn/kubernetes that referenced this pull request Jul 17, 2025
TODO: this commit may be dropped once kcp-dev/kcp#3274 and related issues are done

Signed-off-by: Karol Szwaj <[email protected]>

On-behalf-of: @SAP [email protected]
Signed-off-by: Nelo-T. Wallus <[email protected]>
ntnn pushed a commit to ntnn/kubernetes that referenced this pull request Jul 18, 2025
TODO: this commit may be dropped once kcp-dev/kcp#3274 and related issues are done

Signed-off-by: Karol Szwaj <[email protected]>

On-behalf-of: @SAP [email protected]
Signed-off-by: Nelo-T. Wallus <[email protected]>
@kcp-ci-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@kcp-ci-bot kcp-ci-bot closed this Aug 13, 2025
@kcp-ci-bot
Copy link
Contributor

@kcp-ci-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ntnn pushed a commit to ntnn/kubernetes that referenced this pull request Aug 21, 2025
TODO: this commit may be dropped once kcp-dev/kcp#3274 and related issues are done

Signed-off-by: Karol Szwaj <[email protected]>

On-behalf-of: @SAP [email protected]
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
ntnn pushed a commit to ntnn/kubernetes that referenced this pull request Aug 21, 2025
TODO: this commit may be dropped once kcp-dev/kcp#3274 and related issues are done

Signed-off-by: Karol Szwaj <[email protected]>

On-behalf-of: @SAP [email protected]
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
ntnn pushed a commit to ntnn/kubernetes that referenced this pull request Aug 21, 2025
TODO: this commit may be dropped once kcp-dev/kcp#3274 and related issues are done

Signed-off-by: Karol Szwaj <[email protected]>

On-behalf-of: @SAP [email protected]
Signed-off-by: Nelo-T. Wallus <[email protected]>
SimonTheLeg pushed a commit to SimonTheLeg/kcp-kubernetes that referenced this pull request Nov 7, 2025
TODO: this commit may be dropped once kcp-dev/kcp#3274 and related issues are done

Signed-off-by: Karol Szwaj <[email protected]>

On-behalf-of: @SAP [email protected]
Signed-off-by: Nelo-T. Wallus <[email protected]>
SimonTheLeg pushed a commit to SimonTheLeg/kcp-kubernetes that referenced this pull request Nov 12, 2025
TODO: this commit may be dropped once kcp-dev/kcp#3274 and related issues are done

Signed-off-by: Karol Szwaj <[email protected]>

On-behalf-of: @SAP [email protected]
Signed-off-by: Nelo-T. Wallus <[email protected]>
SimonTheLeg pushed a commit to SimonTheLeg/kcp-kubernetes that referenced this pull request Nov 12, 2025
TODO: this commit may be dropped once kcp-dev/kcp#3274 and related issues are done

Signed-off-by: Karol Szwaj <[email protected]>

On-behalf-of: @SAP [email protected]
Signed-off-by: Nelo-T. Wallus <[email protected]>
SimonTheLeg pushed a commit to SimonTheLeg/kcp-kubernetes that referenced this pull request Nov 13, 2025
TODO: this commit may be dropped once kcp-dev/kcp#3274 and related issues are done

Signed-off-by: Karol Szwaj <[email protected]>

On-behalf-of: @SAP [email protected]
Signed-off-by: Nelo-T. Wallus <[email protected]>
@mjudeikis
Copy link
Contributor

We need to revist this

@mjudeikis mjudeikis reopened this Dec 8, 2025
@kcp-ci-bot kcp-ci-bot added the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Dec 8, 2025
@kcp-ci-bot
Copy link
Contributor

@sttts: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kcp-test-e2e 82d13e5 link true /test pull-kcp-test-e2e
pull-kcp-test-e2e-sharded 82d13e5 link true /test pull-kcp-test-e2e-sharded
pull-kcp-test-e2e-shared 82d13e5 link true /test pull-kcp-test-e2e-shared
pull-kcp-test-e2e-multiple-runs 82d13e5 link true /test pull-kcp-test-e2e-multiple-runs
pull-kcp-test-unit 82d13e5 link true /test pull-kcp-test-unit
pull-kcp-lint 82d13e5 link true /test pull-kcp-lint
pull-kcp-validate-prow-yaml 82d13e5 link true /test pull-kcp-validate-prow-yaml

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mjudeikis pushed a commit to mjudeikis/kubernetes that referenced this pull request Dec 8, 2025
TODO: this commit may be dropped once kcp-dev/kcp#3274 and related issues are done

Signed-off-by: Karol Szwaj <[email protected]>

On-behalf-of: @SAP [email protected]
Signed-off-by: Nelo-T. Wallus <[email protected]>
mjudeikis pushed a commit to kcp-dev/kubernetes that referenced this pull request Dec 9, 2025
TODO: this commit may be dropped once kcp-dev/kcp#3274 and related issues are done

Signed-off-by: Karol Szwaj <[email protected]>

On-behalf-of: @SAP [email protected]
Signed-off-by: Nelo-T. Wallus <[email protected]>
@kcp-ci-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@kcp-ci-bot kcp-ci-bot closed this Jan 7, 2026
@kcp-ci-bot
Copy link
Contributor

@kcp-ci-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjudeikis
Copy link
Contributor

/reopen
/remove-lifecycle rotten

@kcp-ci-bot kcp-ci-bot reopened this Jan 7, 2026
@kcp-ci-bot
Copy link
Contributor

@mjudeikis: Reopened this PR.

Details

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants