Skip to content

Maintain a minimum and a build go version #3515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 9, 2025
Merged

Maintain a minimum and a build go version #3515

merged 4 commits into from
Aug 9, 2025

Conversation

@ntnn
Copy link
Member

@ntnn ntnn commented Aug 6, 2025 •
edited
Loading

Summary

See #3511 (review)

Updates the script to maintain the minimum and build version in go.mod.

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2025
@ntnn
Copy link
Member Author

ntnn commented Aug 6, 2025

/retest

flake without output

@ntnn ntnn force-pushed the improve-go-version-check branch from ba50374 to 028ec45 Compare August 6, 2025 20:34
@ntnn ntnn force-pushed the improve-go-version-check branch from 028ec45 to 2b2dc6b Compare August 6, 2025 20:42
@ntnn ntnn force-pushed the improve-go-version-check branch from 2b2dc6b to 8df0722 Compare August 6, 2025 20:47
@ntnn
Copy link
Member Author

ntnn commented Aug 6, 2025 •
edited
Loading

/retest

Have seen that flake a couple times recently

https://public-prow.kcp.k8c.io/view/s3/prow-public-data/pr-logs/pull/kcp-dev_kcp/3515/pull-kcp-test-e2e-sharded/1953196286312189952

TestWorkspaceController/add_a_shard_after_a_workspace_is_unschedulable,_expect_it_to_be_scheduled

embik
embik reviewed Aug 7, 2025
View reviewed changes
@ntnn
Copy link
Member Author

ntnn commented Aug 7, 2025

/retest

@ntnn
Copy link
Member Author

ntnn commented Aug 7, 2025 •
edited
Loading

/retest

known flake TestAPIExportBindingAuthorizer #3444

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Aug 7, 2025

@ntnn: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /build-image
  • /test pull-kcp-build-image
  • /test pull-kcp-lint
  • /test pull-kcp-test-e2e
  • /test pull-kcp-test-e2e-multiple-runs
  • /test pull-kcp-test-e2e-sharded
  • /test pull-kcp-test-e2e-shared
  • /test pull-kcp-test-integration
  • /test pull-kcp-test-unit
  • /test pull-kcp-validate-prow-yaml
  • /test pull-kcp-verify
  • /test pull-kcp-verify-codegen

Use /test all to run the following jobs that were automatically triggered:

  • pull-kcp-build-image
  • pull-kcp-lint
  • pull-kcp-test-e2e
  • pull-kcp-test-e2e-multiple-runs
  • pull-kcp-test-e2e-sharded
  • pull-kcp-test-e2e-shared
  • pull-kcp-test-integration
  • pull-kcp-test-unit
  • pull-kcp-validate-prow-yaml
  • pull-kcp-verify
  • pull-kcp-verify-codegen

In response to this:

/retest known flake TestAPIExportBindingAuthorizer

#3444

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ntnn
Copy link
Member Author

ntnn commented Aug 7, 2025 •
edited
Loading

/retest

known flake TestAPIExportBindingAuthorizer #3444

https://public-prow.kcp.k8c.io/view/s3/prow-public-data/pr-logs/pull/kcp-dev_kcp/3515/pull-kcp-test-e2e-sharded/1953383941679353856

@mjudeikis
Copy link
Contributor

mjudeikis commented Aug 9, 2025

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2025
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Aug 9, 2025

LGTM label has been added.

Git tree hash: 7cdd0c6d34e9e9ae8be6ad24fbc8e3b787c26655

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Aug 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2025
@ntnn
Copy link
Member Author

ntnn commented Aug 9, 2025

/retest

∅ test/integration/dynamicrestmapper/assets
✓ test/integration/dynamicrestmapper (47.031s)
✓ test/integration/workspace (1m1.778s)
✖ test/integration/framework (1m33.045s)

=== Failed
=== FAIL: test/integration/framework TestServer (unknown)

DONE 5 tests, 1 failure in 96.647s
make: *** [Makefile:380: test-integration] Error 1

  • EXIT_CODE=2
  • set +o xtrace

o.O probably infra error

@ntnn
Copy link
Member Author

ntnn commented Aug 9, 2025

/retest

same error again

@kcp-ci-bot kcp-ci-bot merged commit 047dc20 into kcp-dev:main Aug 9, 2025
14 checks passed
@ntnn ntnn deleted the improve-go-version-check branch August 9, 2025 20:28
@ntnn ntnn mentioned this pull request Aug 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@embik embik embik left review comments

Assignees

@mjudeikis mjudeikis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ntnn @kcp-ci-bot @mjudeikis @embik