-
Notifications
You must be signed in to change notification settings - Fork 424
Fix kcp casing once and for all #3665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
LGTM label has been added. Git tree hash: d9923af3dfee347737df83329aef52217b7d40d5
|
|
New changes are detected. LGTM label has been removed. |
|
/retest |
|
|
||
| ## What does kcp stand for / how to spell it? | ||
|
|
||
| `kcp` stands for "Kube for Control Plane" and should always be written in lowercase letters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaik our official position is that it doesn't stand for anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought so too, but then I found https://github.com/kcp-dev/kcp/blob/main/cmd/kcp/kcp.go#L51.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also remember someone telling me that kcp effectively stands for nothing and CERTAINLY NOT "Kubernetes control plane", but since then I heard many folks use the "kube for control plane" mantra.
No real opinion on my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would vote for kcp - Kubernetes-like Control Planes. This was clicked in my head for a long time.
I leave the final vote for @sttts :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for @mjudeikis's proposal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"kcp - Kcp Control Plane" 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"K-ControlPlane"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can agree with MJ's earlier proposal ("kcp - Kubernetes-like Control Planes") if CNCF allows it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we check with cncf?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked with CNCF folks and the inofficial statement through the grapevines was:
- [this decision] should not need CNCF approval
- [kcp devs] must just make sure to follow kcp governance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just close the one pending and merge
| Short: "kubectl plugin for kcp", | ||
| Long: help.Doc(` | ||
| KCP is the easiest way to manage Kubernetes applications against one or | ||
| kcp is the easiest way to manage Kubernetes applications against one or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove this Kubernetes applications against. Applications are confusing.
ALl thi section is somehow wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced it with the current short intro we have in our Readme/docs.
|
|
||
| ## What does kcp stand for / how to spell it? | ||
|
|
||
| `kcp` stands for "Kube for Control Plane" and should always be written in lowercase letters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would vote for kcp - Kubernetes-like Control Planes. This was clicked in my head for a long time.
I leave the final vote for @sttts :)
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@xrstf: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Summary
It irks me that it's sometimes
kcp, sometimesKCPand in extreme cases evenKcp. For no technical reason other than consistency, I vote that we enshrine the correct spelling (all lowercase) in the FAQ and adjust all files accordingly.This PR also fixes the rebasing docs a bit and adds a note that they are probably severely outdated since we moved to monorepo. The sample screenshot of GitHub is now included as well and shrunk by optipng by nearly 50% :)
I did not touch the boilerplate header as I am not sure about the CNCF rammifications, but I would personally of course also change them. If we can.
What Type of PR Is This?
/kind cleanup
Release Notes