Skip to content

e2e: set images to known multiarch versions#1379

Closed
wozniakjan wants to merge 1 commit intokedacore:mainfrom
wozniakjan:e2e_trigger
Closed

e2e: set images to known multiarch versions#1379
wozniakjan wants to merge 1 commit intokedacore:mainfrom
wozniakjan:e2e_trigger

Conversation

@wozniakjan
Copy link
Copy Markdown
Member

@wozniakjan wozniakjan commented Nov 25, 2025

e2e tests work for AMD64, but many of them started to fail for ARM64. The issue seems to be that some images have been newly built as AMD64 only and not multiarch:

$ docker manifest inspect ghcr.io/kedacore/tests-apache-ab | jq '.mediaType'
"application/vnd.oci.image.index.v1+json"

$ docker manifest inspect ghcr.io/kedacore/tests-apache-ab:8f3801e | jq '.mediaType'
"application/vnd.docker.distribution.manifest.v2+json"

This PR pins the images to the latest multiarch versions so ARM64 tests can pass.

see also: kedacore/test-tools#234

@snyk-io
Copy link
Copy Markdown

snyk-io bot commented Nov 25, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@wozniakjan wozniakjan force-pushed the e2e_trigger branch 2 times, most recently from 3d493ad to 7c40eb1 Compare November 25, 2025 12:24
@wozniakjan wozniakjan changed the title [DO NOT MERGE] debug e2e test failure e2e: pin images to latest known multiarch versions Nov 25, 2025
@wozniakjan wozniakjan force-pushed the e2e_trigger branch 2 times, most recently from eeaebfc to 31e7de9 Compare November 25, 2025 15:50
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
@wozniakjan wozniakjan changed the title e2e: pin images to latest known multiarch versions e2e: pick images to known multiarch versions Nov 25, 2025
@wozniakjan wozniakjan changed the title e2e: pick images to known multiarch versions e2e: set images to known multiarch versions Nov 25, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses ARM64 test failures by pinning test container images to known multiarch versions. The issue arose because some kedacore test images were recently rebuilt as AMD64-only, causing ARM64 e2e tests to fail. The PR updates image references from untagged (latest) versions to the http-add-on-e2e tag which contains multiarch manifests.

  • Updates ghcr.io/kedacore/tests-apache-ab images across multiple scaling phase tests to use the http-add-on-e2e tag
  • Updates ghcr.io/kedacore/tests-websockets image to use the http-add-on-e2e tag
  • Modifies ghcr.io/vi/websocat to remove version pinning

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/checks/scaling_phase_statefulset/scaling_phase_statefulset_test.go Pins apache-ab load generator image to http-add-on-e2e tag for multiarch support
tests/checks/scaling_phase_deployment_with_skip_so_creation/scaling_phase_deployment_with_skip_so_creation_test.go Pins apache-ab load generator image to http-add-on-e2e tag for multiarch support
tests/checks/scaling_phase_deployment/scaling_phase_deployment_test.go Pins apache-ab load generator image to http-add-on-e2e tag for multiarch support
tests/checks/scaling_phase_custom_resource/scaling_phase_custom_resource_test.go Pins apache-ab load generator image to http-add-on-e2e tag for multiarch support
tests/checks/interceptor_websocket/interceptor_websocket_test.go Updates websockets test image to http-add-on-e2e tag and removes version from websocat image

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JorTurFer
Copy link
Copy Markdown
Member

let me look our build process before pinning these versions please

@JorTurFer
Copy link
Copy Markdown
Member

e2e tests work for AMD64, but many of them started to fail for ARM64. The issue seems to be that some images have been newly built as AMD64 only and not multiarch:

$ docker manifest inspect ghcr.io/kedacore/tests-apache-ab | jq '.mediaType'
"application/vnd.oci.image.index.v1+json"

$ docker manifest inspect ghcr.io/kedacore/tests-apache-ab:8f3801e | jq '.mediaType'
"application/vnd.docker.distribution.manifest.v2+json"

This PR pins the images to the latest multiarch versions so ARM64 tests can pass.

see also: kedacore/test-tools#234

I'm checking ghcr.io/kedacore/tests-apache-ab (built 2 months ago) and it has all our supported arch (AMD, ARM and s390x)

image

@wozniakjan
Copy link
Copy Markdown
Member Author

I'm checking ghcr.io/kedacore/tests-apache-ab (built 2 months ago) and it has all our supported arch (AMD, ARM and s390x)

right, the images are kind of multiarch, but the binaries there are amd64 always which results in that failure

1830 2025-11-25T16:45:33.2342601Z     scaling_phase_deployment_test.go:175: jobs logs: [pod/load-generator-kvkz2/apache-ab] exec /usr/bin/ab: exec format error

@wozniakjan
Copy link
Copy Markdown
Member Author

fixed by kedacore/test-tools#234

@wozniakjan wozniakjan closed this Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants