e2e: set images to known multiarch versions#1379
e2e: set images to known multiarch versions#1379wozniakjan wants to merge 1 commit intokedacore:mainfrom
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
3d493ad to
7c40eb1
Compare
eeaebfc to
31e7de9
Compare
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
0d3105c to
79a4923
Compare
There was a problem hiding this comment.
Pull request overview
This PR addresses ARM64 test failures by pinning test container images to known multiarch versions. The issue arose because some kedacore test images were recently rebuilt as AMD64-only, causing ARM64 e2e tests to fail. The PR updates image references from untagged (latest) versions to the http-add-on-e2e tag which contains multiarch manifests.
- Updates
ghcr.io/kedacore/tests-apache-abimages across multiple scaling phase tests to use thehttp-add-on-e2etag - Updates
ghcr.io/kedacore/tests-websocketsimage to use thehttp-add-on-e2etag - Modifies
ghcr.io/vi/websocatto remove version pinning
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/checks/scaling_phase_statefulset/scaling_phase_statefulset_test.go | Pins apache-ab load generator image to http-add-on-e2e tag for multiarch support |
| tests/checks/scaling_phase_deployment_with_skip_so_creation/scaling_phase_deployment_with_skip_so_creation_test.go | Pins apache-ab load generator image to http-add-on-e2e tag for multiarch support |
| tests/checks/scaling_phase_deployment/scaling_phase_deployment_test.go | Pins apache-ab load generator image to http-add-on-e2e tag for multiarch support |
| tests/checks/scaling_phase_custom_resource/scaling_phase_custom_resource_test.go | Pins apache-ab load generator image to http-add-on-e2e tag for multiarch support |
| tests/checks/interceptor_websocket/interceptor_websocket_test.go | Updates websockets test image to http-add-on-e2e tag and removes version from websocat image |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
let me look our build process before pinning these versions please |
I'm checking ghcr.io/kedacore/tests-apache-ab (built 2 months ago) and it has all our supported arch (AMD, ARM and s390x)
|
right, the images are kind of multiarch, but the binaries there are amd64 always which results in that failure |
|
fixed by kedacore/test-tools#234 |

e2e tests work for AMD64, but many of them started to fail for ARM64. The issue seems to be that some images have been newly built as AMD64 only and not multiarch:
This PR pins the images to the latest multiarch versions so ARM64 tests can pass.
see also: kedacore/test-tools#234