e2e images: fix multiarch image build#234
Merged
JorTurFer merged 16 commits intokedacore:mainfrom Nov 26, 2025
Merged
Conversation
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
JorTurFer
approved these changes
Nov 25, 2025
There was a problem hiding this comment.
Pull request overview
This PR fixes a multiarch Docker image build issue for e2e test images where binaries inside the containers were being built for the wrong architecture. By removing the --platform=${BUILDPLATFORM} argument from the FROM statements in two Dockerfiles, the images can now properly be built for multiple target architectures (amd64, arm64, s390x) as intended by the build system.
- Removed
--platform=${BUILDPLATFORM}from the websockets Dockerfile's FROM statement - Removed
--platform=${BUILDPLATFORM}from the apache-ab Dockerfile's FROM statement
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| e2e/images/websockets/Dockerfile | Removed platform specification to allow proper multiarch builds with target platform's Node.js base image |
| e2e/images/apache-ab/Dockerfile | Removed platform specification to allow proper multiarch builds with target platform's Alpine base image |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>
Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>
Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>
Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>
Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>
Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>
Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>
Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>
Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>
Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
followup to #229, the images were built as multiarch but the binaries inside used the
BUILDPLATFORMarch. Removing theBUILDPLATFORMargument allows buildx to use the correct target arch even when host arch is different.see also: kedacore/http-add-on#1379