Replace Dep with New Go 11 Modules#767
Open
msolimans wants to merge 5 commits intokelseyhightower:masterfrom
Open
Replace Dep with New Go 11 Modules#767msolimans wants to merge 5 commits intokelseyhightower:masterfrom
msolimans wants to merge 5 commits intokelseyhightower:masterfrom
Conversation
|
@kelseyhightower any chance on getting this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabled Go 11 Modules; it is the new way to manage dependencies from Go team. much cleaner and easier than ever before. it allows to put the project anywhere without the need to have it inside $GOPATH!
I've updated Makefile too, removed
depand addedmodinstead and also updatevendorwith all required packages that were resolved by go modules (refactored, much better)For more info about new Go 11 Modules, https://github.com/golang/go/wiki/Modules