-
Notifications
You must be signed in to change notification settings - Fork 5
bpf, arm64: Do not audit capability check in do_jit() #6465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bpf-next_base
Are you sure you want to change the base?
bpf, arm64: Do not audit capability check in do_jit() #6465
Conversation
|
Upstream branch: 835a507 |
03e2ed2 to
3ea267d
Compare
|
Upstream branch: 835a507 |
653d428 to
1f65c86
Compare
3ea267d to
6d4eb64
Compare
|
Upstream branch: 835a507 |
1f65c86 to
5840ab8
Compare
6d4eb64 to
af4bac7
Compare
|
Upstream branch: 81f88f6 |
5840ab8 to
70cc72c
Compare
af4bac7 to
6ba2fc1
Compare
|
Upstream branch: 5d9fb42 |
Analogically to the x86 commit 881a9c9 ("bpf: Do not audit capability check in do_jit()"), change the capable() call to ns_capable_noaudit() in order to avoid spurious SELinux denials in audit log. The commit log from that commit applies here as well: """ The failure of this check only results in a security mitigation being applied, slightly affecting performance of the compiled BPF program. It doesn't result in a failed syscall, an thus auditing a failed LSM permission check for it is unwanted. For example with SELinux, it causes a denial to be reported for confined processes running as root, which tends to be flagged as a problem to be fixed in the policy. Yet dontauditing or allowing CAP_SYS_ADMIN to the domain may not be desirable, as it would allow/silence also other checks - either going against the principle of least privilege or making debugging potentially harder. Fix it by changing it from capable() to ns_capable_noaudit(), which instructs the LSMs to not audit the resulting denials. """ Fixes: f300769 ("arm64: bpf: Only mitigate cBPF programs loaded by unprivileged users") Signed-off-by: Ondrej Mosnacek <[email protected]>
70cc72c to
b1c2ae1
Compare
Pull request for series with
subject: bpf, arm64: Do not audit capability check in do_jit()
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1030464