Add more github_sync unit tests #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theihor
force-pushed
the
sync-test
branch
2 times, most recently
from
07e3f3f to
4a144f7
Compare
theihor
changed the title
Add a comprehensive test covering most of the sync_patches logic. Extend patchwork_mock to be able to load test responses from disk if appropriate. Use realistic json responses for this test to make KPD trigger relevant http calls. Signed-off-by: Ihor Solodrai <[email protected]>
Factor out sync_relevant_subject() routine from sync_patches() Add test cases verifying base branch selection logic, when applying the series. Signed-off-by: Ihor Solodrai <[email protected]>
A couple of helper functions refered to "series/123" part of a branch
name ("series/123=>target") as "base" which is quite confusing.
Refactor helpers that were parsing PR refs and their usage.
Move separator constants used for branch names to config.py
Signed-off-by: Ihor Solodrai <[email protected]>
Using @Property and async on the same function is confusing and makes mocking for unit tests difficult and sometimes impossible. Remove @Property decorator from Subject getters and make them simple async functions. Fix usages accordingly. Signed-off-by: Ihor Solodrai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before implementing #6 I wanted to have a good test coverage of the relevant code.
To get that, I wanted to add a number of tests, and to enable that some refactoring was appropriate.
See individual commits for details.