feat(web): remove 'export default' to eliminate more aliases 🎼 #15401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #15292 Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
darcywong00
approved these changes
Jan 8, 2026
| code += '\n' + LMLayerWorkerSourcemapComment; | ||
| // } | ||
| let blob = new Blob([code], { type: 'text/javascript' }); | ||
| const blob = new Blob([code], { type: 'text/javascript' }); |
Contributor
There was a problem hiding this comment.
Sneaking in a different change 😉 I'll allow it
| export type PhoneKeyTipOrientation = 'top' | 'bottom'; | ||
|
|
||
| export default class KeyTip implements KeyTipInterface { | ||
| export class PhoneKeyTip implements KeyTip { |
Contributor
There was a problem hiding this comment.
Can we mention this rename in the PR description?
mcdurdin
approved these changes
Jan 8, 2026
Member
mcdurdin
left a comment
mcdurdin
left a comment
There was a problem hiding this comment.
Two comments for a follow-up PR -- best not to add to this already large set of changes in this PR. LGTM, great to eliminate this source of confusion, looks like most default exports were not renamed but it was a fragile pattern!
Co-authored-by: Marc Durdin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rename
KeyTiptoPhoneKeyTip.Fixes: #15292
Test-bot: skip