Skip to content

Conversation

@mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Nov 1, 2024

@mcdurdin mcdurdin added this to the A18S14 milestone Nov 1, 2024
@mcdurdin mcdurdin added the chore label Nov 1, 2024
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

php_value display_startup_errors on
php_value display_errors stderr
</IfFile>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the related PRs had

php_value include_path ".:/var/www/html/_includes/"

Is that not needed or handled elsewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, that is handled in /resources/keyman-site.conf. We should probably consolidate (even consider moving away from .htaccess for performance reasons) but that can happen in a later PR

Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcdurdin mcdurdin merged commit d34b4f5 into master Nov 1, 2024
@mcdurdin mcdurdin deleted the chore/support-debug-mode branch November 1, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants