Skip to content

chore: support debug mode #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcdurdin merged 2 commits into from
Nov 1, 2024
Merged

chore: support debug mode #123

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6f80b1
chore: support debug mode
mcdurdin Nov 1, 2024
a525dd4
chore: Update build.sh to v0.11
mcdurdin Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@ cdn/deploy
resources/bootstrap.inc.sh
resources/.bootstrap-version
_common/

# State files
_control/debug
12 changes: 11 additions & 1 deletion .htaccess
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,19 @@

php_value display_errors off
php_value display_startup_errors off

<IfFile /var/www/html/_control/debug>
php_value display_startup_errors on
php_value display_errors stderr
</IfFile>

Copy link
Contributor

@darcywong00 darcywong00 Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the related PRs had

php_value include_path ".:/var/www/html/_includes/"

Is that not needed or handled elsewhere?

Copy link
Member Author

@mcdurdin mcdurdin Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, that is handled in /resources/keyman-site.conf. We should probably consolidate (even consider moving away from .htaccess for performance reasons) but that can happen in a later PR


<IfModule mod_headers.c>
Header set Access-Control-Allow-Origin "*"
</IfModule>
<IfModule mod_mime.c>
AddType font/ttf .ttf
AddType application/javascript .js
AddType application/javascript .js

AddCharset UTF-8 .js
</IfModule>
Expand Down
2 changes: 1 addition & 1 deletion build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
## START STANDARD SITE BUILD SCRIPT INCLUDE
readonly THIS_SCRIPT="$(readlink -f "${BASH_SOURCE[0]}")"
readonly BOOTSTRAP="$(dirname "$THIS_SCRIPT")/resources/bootstrap.inc.sh"
readonly BOOTSTRAP_VERSION=v0.10
readonly BOOTSTRAP_VERSION=chore/v0.11
[ -f "$BOOTSTRAP" ] && source "$BOOTSTRAP" || source <(curl -fs https://raw.githubusercontent.com/keymanapp/shared-sites/$BOOTSTRAP_VERSION/bootstrap.inc.sh)
## END STANDARD SITE BUILD SCRIPT INCLUDE

Expand Down