[FEATURE] Update Mediaplayer file detection#1892
Open
fschoelzel wants to merge 9 commits intokitodo:mainfrom
Open
[FEATURE] Update Mediaplayer file detection#1892fschoelzel wants to merge 9 commits intokitodo:mainfrom
fschoelzel wants to merge 9 commits intokitodo:mainfrom
Conversation
- use Audio and Video Use Groups - refactor `MediaplayerController` using media instead of video
…and TypeProvider - add ExpressionLanguage functions to to set typoscript variables on pageload to determine physical type
…class - update data-attribute to more precise naming
Contributor
Author
|
I don't have this Error running the unit test loacally with php82. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1879
useGroupsAudiofor Audio Files (instead mixing it in theuseGroupsVideoas before the removement of the Audioplayer plugin see: [MAINTENANCE] Remove jPlayer and dlf_audioplayer Plugin #1878)mediainstead ofvideoto highlight the dual use and for better understandingMediaPlayerServiceClass for the distinction between Audio and Video Files. This is used inMediaPlayerControllerand in two new ExpressionLanguage Functions to set the variables to load the related TemplatesMediaTypeFunctionProviderwith newisAudioandisVideoExpressionLanguage Functions can be used in typoscript configurationmultivolume_workDocuments by reading Information from MetsDocumentPHYSICALStructure based on the Filegroup and useGroup Configuration, instead of the metadata (LOGICALStructure)wavesurfer.jsfrom node dependencies, because it is not used in the codebase