Skip to content

[3.9] Fix folder editing and deleting#6986

Draft
BartChris wants to merge 3 commits intokitodo:3.9.xfrom
BartChris:3-9-folder_editing_fix
Draft

[3.9] Fix folder editing and deleting#6986
BartChris wants to merge 3 commits intokitodo:3.9.xfrom
BartChris:3-9-folder_editing_fix

Conversation

@BartChris
Copy link
Copy Markdown
Collaborator

Backport of #6946

@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 14, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics -1 complexity · 5 duplication

Metric Results
Complexity -1
Duplication 5

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@BartChris BartChris marked this pull request as ready for review April 14, 2026 16:18
@BartChris BartChris marked this pull request as draft April 16, 2026 14:29
@solth
Copy link
Copy Markdown
Member

solth commented Apr 16, 2026

I still get the following uncaught error when changing the FILEGROUP of an existing folder to a value that is already used in another folder:

Bildschirmfoto 2026-04-16 um 16 26 57

Your fix in main handled this error better by just displaying the error message (even though the content is a little questionable: "Dateigruppe wird bereits verwendet: .folders") and not the error page including the whole stack trace (which is still documented in the log, though):

Bildschirmfoto 2026-04-16 um 16 30 43

@BartChris
Copy link
Copy Markdown
Collaborator Author

BartChris commented Apr 16, 2026

@solth I pushed a fix for that. I suppose it would also be better to integrate that in Main, although it does not lead to an exception there. The switch to ViewScoped leads to behavior differences, so that this does not crash there.

@BartChris
Copy link
Copy Markdown
Collaborator Author

I also backported the changes here:
#6993

@BartChris BartChris force-pushed the 3-9-folder_editing_fix branch from 3cbaa50 to b6f2f09 Compare April 16, 2026 15:57
@BartChris BartChris force-pushed the 3-9-folder_editing_fix branch from b6f2f09 to 4a61b9e Compare April 16, 2026 16:15
@BartChris BartChris added the project management project and template related topics label Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project management project and template related topics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants