Draft
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 6 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
BartChris
commented
Apr 16, 2026
| private Map<String, Folder> getFolderMap() { | ||
| return getFolderList().parallelStream().collect(Collectors.toMap(Folder::getFileGroup, Function.identity())); | ||
| return getFolderList().stream() | ||
| .filter(folder -> StringUtils.isNotBlank(folder.getFileGroup())) |
Collaborator
Author
There was a problem hiding this comment.
This is a change in behavior. I suppose it is safer, but empty file groups are not forbidden by the UI in general. It might be that they lead to problems downstream.
I will also check whether we can also include blank file groups here.
BartChris
force-pushed
the
folder_editing_stream
branch
from
efaacc8 to
43d7dfc
Compare
BartChris
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves upon #6946.
When i edit folders and in the same UI interaction session also edit the folder usage (Which folder is user to show thumbnails etc.) sometimes the screen gets stuck on Save. It seems to me as if using "parallel stream" is not safe here and has unwanted effects. After my changes i can edit both the general folder settings as well as their usage.
I also improve the file group handlung insofar as when a filegroup of an existing folder is changed to the filegroup of another folder, we do not actually switch the file group.